Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes not displayed in summary #1

Open
wimleers opened this issue Jul 12, 2019 · 4 comments
Open

Includes not displayed in summary #1

wimleers opened this issue Jul 12, 2019 · 4 comments

Comments

@wimleers
Copy link

First of all: fantastic work! 🥳👏🤩

I built a query that uses a sparse fieldset and includes. This works great. But the summary only shows the 3 articles, not the included authors, even though those are present in the raw response.

See at: https://explore.jsonapi.dev/?location=https%3A%2F%2Fexample.jsonapi.dev%2Fjsonapi%2Fnode%2Farticle%3Finclude%3Duid%26filter%5Bstatus%5D%3D1%26fields%5Bnode--article%5D%3Dtitle

P.S.: It's awesome I can just share a URL to allow you to reproduce a bug!

@wimleers
Copy link
Author

Oh and in doing that, I realized that I cannot select uid in the sparse fieldset, which is necessary to be able to relate included authors (uid) to articles.

@gabesullice
Copy link
Collaborator

gabesullice commented Jul 12, 2019

@wimleers if you undo your sparse fieldset, look at the uid field row for the "∈" character. Click it. This will update the summary go "down" the relationship. You'll then see the include. There's a button to go "up" which will show you the referencing field.

The "∈" link is really non-descript, I'm not surprised that you missed it. It was just a placeholder until we could get more design direction.

===

All that said, that won't work if you do not have the relationship in the sparse fieldset, which is the second issue you brought up. Without it, you can't go "down" a level. I think that's the primary bug that needs to be resolved in this issue. I updates the issue title accordingly.

@wimleers
Copy link
Author

Hm … if I don’t see the uid row, how can I see ∈? I wonder what I'm missing :) Using Chrome, by the way.

@gabesullice
Copy link
Collaborator

All that said, that won't work if you do not have the relationship in the sparse fieldset, which is the second issue you brought up.

You have to completely remove the sparse fieldset to see the uid row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@wimleers @gabesullice and others