Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WebWorkers #22

Closed
jayfunk opened this issue Sep 14, 2015 · 2 comments
Closed

Support for WebWorkers #22

jayfunk opened this issue Sep 14, 2015 · 2 comments

Comments

@jayfunk
Copy link

jayfunk commented Sep 14, 2015

stream-http assumes a normal browser window and not a worker, though http requests in a worker are legitimate.

Inside a webworker the global object is self not window.

Original issue in http-browserify.

@jhiesey
Copy link
Owner

jhiesey commented Sep 14, 2015

Hm, it's very easy to just replace window with global, but I wonder if there's anything else that is different between workers and the window.

I'll add a test for WebWorker support before merging that change.

@jhiesey
Copy link
Owner

jhiesey commented Sep 15, 2015

Fixed by 8cab16f

@jhiesey jhiesey closed this as completed Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants