Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/watchflakes: fails to parse the "!~" operator #71119

Open
dmitshur opened this issue Jan 4, 2025 · 2 comments
Open

x/build/cmd/watchflakes: fails to parse the "!~" operator #71119

dmitshur opened this issue Jan 4, 2025 · 2 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jan 4, 2025 •
edited
Loading

Both of these scripts should parse successfully:

default <- pkg == "cmd/go" && output ~ `some regexp`
default <- pkg == "cmd/go" && output !~ `some regexp`

Yet the latter doesn't, producing an "unexpected !" error. See #66337 (comment) and #66337 (comment) for more context.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. labels Jan 4, 2025
@dmitshur dmitshur added this to the Unreleased milestone Jan 4, 2025
@dmitshur dmitshur self-assigned this Jan 4, 2025
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/640295 mentions this issue: cmd/watchflakes: add some script parsing tests

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/640275 mentions this issue: cmd/watchflakes/internal/script: lex !~ as a single token

@dmitshur dmitshur moved this to In Progress in Go Release Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Status: In Progress
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot