x/tools/gopls: minmax modernization introduces errors

[pjweinb]

The original code is
// Don't refresh more than twice per minute.
delay := 30 * time.Second
// Don't spend more than ~2% of the time refreshing.
if adaptive := 50 * t.duration; adaptive > delay {
delay = adaptive
}
and it says 'if statement can be modernized using max', pointing to 'adaptive > delay'. For the above code it substitutes
// Don't refresh more than twice per minute.
delay := max(adaptive, delay)
which is syntactically (neither delay not adaptive have been defined) and semantically wrong.

[findleyr]

Thanks for reporting.

CC @adonovan

[gopherbot]

Change https://go.dev/cl/640038 mentions this issue: internal/analysis/modernize: minmax: don't reduce to y:=min(x, y)

[gopherbot]

Change https://go.dev/cl/640037 mentions this issue: internal/analysis/modernize: minmax: reject IfStmt with Init