Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: TestVerifyConnection/TLSv12 failures [1.23 backport] #71104

Open
gopherbot opened this issue Jan 3, 2025 · 3 comments
Open

crypto/tls: TestVerifyConnection/TLSv12 failures [1.23 backport] #71104

gopherbot opened this issue Jan 3, 2025 · 3 comments
Labels
CherryPickCandidate Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.23.5

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Jan 3, 2025 •
edited by gabyhelp
Loading

@FiloSottile requested issue #71077 to be considered for backport to the next 1.23 minor release.

@gopherbot please open backport issues for CL 639655. Tests are broken across releases.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 3, 2025
@gopherbot gopherbot mentioned this issue Jan 3, 2025
Closed
@gopherbot gopherbot added this to the Go1.23.5 milestone Jan 3, 2025
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jan 3, 2025
@dmitshur
Copy link
Contributor

dmitshur commented Jan 3, 2025 •
edited
Loading

I tried creating backports, but there are some merge conflicts. @FiloSottile If you don't mind and have a chance, perhaps it's easier for you to resolve them and send the CLs for review. Thanks.

(We haven't reviewed this backport yet, but it's clear we'll need to either skip or fix the tests.)

@FiloSottile
Copy link
Contributor

The Go 1.23 backport is hitting a difference in behavior that I can't yet explain, I'll try to figure it out tomorrow.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/640315 mentions this issue: [release-branch.go1.23] crypto/tls: fix Config.Time in tests using expired certificates

@milantracy milantracy mentioned this issue Jan 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.23.5
Development

No branches or pull requests
3 participants
@FiloSottile @dmitshur @gopherbot