Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor(v3): Update SSE recipe to use Buffered Streaming #2709

Open
grivera64 opened this issue Nov 27, 2024 · 3 comments
Open

♻️ Refactor(v3): Update SSE recipe to use Buffered Streaming #2709

grivera64 opened this issue Nov 27, 2024 · 3 comments

Comments

@grivera64
Copy link
Member

grivera64 commented Nov 27, 2024

Is your feature request related to a problem?

This issue is related to the recently merged PR for fiber/v3 the main repo: fiber#3131.

This issue proposes to update the SSE recipe to take advantage of this new v3 feature.

Describe the solution you'd like

This issue is to track updating the call c.Status(fiber.StatusOK).Context().SetBodyStreamWriter(fasthttp.StreamWriter(...)) to instead use c.Status(fiber.StatusOK).SendStreamWriter(...).

We should also update the markdown tutorial as well for SSE.

Describe alternatives you've considered

N/A

Additional context

This update is from a v2->v3 change. It may be a good idea to use a separate migration branch for this change to later merge into master when v3 is officially released.

Copy link

welcome bot commented Nov 27, 2024

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template!

@grivera64
Copy link
Member Author

I was thinking, should we make a main branch to house all v2->v3 updates (e.g. v3-migration)? This way, we can contain all v3 updates into one simple merge once v3 is officially released.

If not, I can add this make a PR to a separate branch (e.g. v3-migration/sse-using-buffered-streams) and we can merge it directly into master once v3 is released.

@gaby
Copy link
Member

gaby commented Dec 4, 2024

@grivera64 Let me cleanup the readmes/go.mods first. Then we could prob do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants