Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce strict versioning for all dependencies in package.json #293

Open
4 tasks
shige opened this issue Jan 7, 2025 · 1 comment
Open
4 tasks

Enforce strict versioning for all dependencies in package.json #293

shige opened this issue Jan 7, 2025 · 1 comment
Assignees
Labels
help wanted Extra attention is needed

Comments

@shige
Copy link
Member

shige commented Jan 7, 2025

Task description

Enforce strict versioning for all dependencies in package.json.

Background

Currently, some dependencies in package.json use version ranges (e.g., ^, ~), allowing for automatic minor or patch updates. This can lead to unexpected behavior or breakages when new versions of these dependencies are released. To ensure consistent builds and avoid unpredictable changes, we need to pin all dependency versions to exact matches.

TODO (Optional)

  • Review package.json and identify all dependencies that are not using strict version matching.
  • Modify package.json to specify exact versions for all dependencies (e.g., "1.2.3" instead of "^1.2.3" or "~1.2.3").
  • Verify that the project still builds and functions as expected after the change.
  • Commit and push the changes

Additional notes (Optional)

Refer to the following examples in the package.json file:

  • Good: https://github.com/giselles-ai/giselle/blob/0aa2a8c657b7623aae97fc6fd8280d69940f42ab/package.json#L17
  • Bad: https://github.com/giselles-ai/giselle/blob/0aa2a8c657b7623aae97fc6fd8280d69940f42ab/package.json#L24
  • npm documentation on versioning: https://docs.npmjs.com/cli/v11/configuring-npm/package-json#:~:text=version%20Must%20match%20version%20exactly
@shige shige added the help wanted Extra attention is needed label Jan 7, 2025
@kentaro-m kentaro-m self-assigned this Jan 8, 2025
@kentaro-m
Copy link
Contributor

I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants