Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use team.id instead of team.dbId for user-facing values, such as in URL paths or form parameters. #290

Open
satococoa opened this issue Jan 7, 2025 · 0 comments
Open

Use team.id instead of team.dbId for user-facing values, such as in URL paths or form parameters. #290

satococoa opened this issue Jan 7, 2025 · 0 comments
Assignees
@gentamura
Labels
help wanted Extra attention is needed

Comments

@satococoa
Copy link
Contributor

Task Description

Previously, we didn't have team.id in our database, so we used team.dbId to identify team records. However, dbId should be used as an internal identifier. Using team.id instead of team.dbId in user-facing values enhances security and adheres to best practices.

Now that we have team.id in our schema, let's use it! Please identify all locations where team.dbId is used in user-facing values (such as URL paths and form parameters) and replace them with team.id. Ensure to thoroughly test the changes after implementation.

Background
@satococoa satococoa added the help wanted Extra attention is needed label Jan 7, 2025
@gentamura gentamura self-assigned this Jan 9, 2025
@gentamura gentamura mentioned this issue Jan 9, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gentamura gentamura

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@satococoa @gentamura