Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel]: Overlay Background not removed when navigating away from the page while overlay is open #6623

Closed
renestalder opened this issue Aug 16, 2024 · 1 comment

Comments

@renestalder
Copy link

renestalder commented Aug 16, 2024

Description

Navigating away from overlays does not destroy the overlays properly. The background seems to stay.

Scenario 1: When a page section is rendered inside an overlay and the user clicks the page, the panel correctly navigates to the clicked page but doesn't remove all HTML properties of the overlay from the DOM. The alpha transparent background of the overlay is still visible until the user clicks on it.

Scenario 2: Opening an overlay and then clicking the browser back button.

Expected behavior

Switch to another page by clicking a page in a pagelist rendered inside an overlay or pushing a browser navigation button should remove the complete overlay from the DOM.

To reproduce

  1. Go to the online Kirby Demo.
  2. Go to a page that has a blocks field, like the blog.
  3. Add a block like the image block, that has a configuration overlay.
  4. After adding the block and the overlay for editing the image block is open, press the browser back button.
  5. Now you still see the overlay background.

Your setup

Kirby Version

4.3.0

Console output

No errors in the console.

Your system (please complete the following information)

  • Device: Mac Book
  • OS: macOs 14.6.0
  • Browser: Chromium (via Arc Browser)
  • Version: Based on Chromium version 127.0.6533.120

Additional context

Problem not reproducible in an earlier version I upgraded from, 4.1.2.

@renestalder renestalder changed the title Overlay Background not removed when navigating away from the page while overlay is open [Panel]: Overlay Background not removed when navigating away from the page while overlay is open Aug 16, 2024
@distantnative
Copy link
Member

Duplicate of #6030 - will be fixed soon #6620

@distantnative distantnative closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants