Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to retry after successful stream end #123

Open
eshaz opened this issue May 23, 2022 · 0 comments
Open

Add option to retry after successful stream end #123

eshaz opened this issue May 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@eshaz
Copy link
Owner

eshaz commented May 23, 2022

In IcecastMetadataPlayer, a new option should be added that triggers retry logic after a successful disconnect of a stream. This may help listeners reconnect when a disconnect is caused by something other than a network error, such as the Icecast server / source disconnecting and restarting the stream.

I've seen that the majority of Icecast streams are meant to continue indefinitely, such as with a radio station. In these cases, any disconnect should be treated as an error. This option might make sense to default to true because of this usage pattern.

options.alwaysReconnect: default true

  • Set to true to reconnect after a stream is disconnected for any reason.
    • Retry logic will take place when the stream ends with or without a fetch request error.
    • The stream will end without an error if the Icecast server initiates the disconnect (i.e when a source ends or the Icecast server is restarted).
  • Set to false to stop playback after a stream is disconnected successfully on the server side.
    • Retry logic will take place when the stream ends only with a fetch request error.
@eshaz eshaz added the enhancement New feature or request label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant