Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_bouncecolorscale seems to have no effect #424

Open
4LT opened this issue May 7, 2024 · 3 comments
Open

_bouncecolorscale seems to have no effect #424

4LT opened this issue May 7, 2024 · 3 comments

Comments

@4LT
Copy link
Contributor

4LT commented May 7, 2024

A light source adjacent to an orange wall seems to have no effect on the tint of a nearby off-white wall. Not sure if this is because the orange wall is too dark or what, but I can't detect a hint of orange on the white wall.

lim_4lt_2024-05-06_23-06-36
lim_4lt_2024-05-06_23-06-42

Settings:

_bounce 3
_bouncecolorscale 1

Version: 2.0.0-alpha7-6-g9985d6c8-dirty

@4LT
Copy link
Contributor Author

4LT commented May 7, 2024

I added some debug prints, light_options.bouncecolorscale.value() is returning 0 in the function CacheTextures

@ericwa
Copy link
Owner

ericwa commented May 7, 2024

Cool, I think I can repro this if I set _bouncecolorscale 1 in worldspawn.
Previously I was setting -bouncecolorscale 1 as a light command-line arg.

Does it fix it if you pass -bouncecolorscale 1 as a light command line arg?

@4LT
Copy link
Contributor Author

4LT commented May 7, 2024

Yes, it works now! Although the effect is much more subtle than I had hoped for; I see why, though, the direct lighting is overpowering the bounced light. Emissive surfaces would probably look better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants