Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep8 #13

Open
arthurlutz opened this issue Feb 13, 2019 · 4 comments
Open

pep8 #13

arthurlutz opened this issue Feb 13, 2019 · 4 comments

Comments

@arthurlutz
Copy link
Contributor

It would be nice to have shsd be pep8 compliant, and with a flake8 to check it in tox (is ❤️) and maybe with some continuous integration ?
arthurzenika pushed a commit to arthurlutz/shsd that referenced this issue Feb 13, 2019
[autopep8]
df8701c 
Related to dynamid#13
@arthurlutz arthurlutz mentioned this issue Feb 13, 2019
Merged
@flesueur
Copy link
Contributor

Hi, do you think that autopep8 is sufficient ? Or do you know it there are specific parts of PEP8 which I should look into closely manually ?

@arthurlutz
Copy link
Contributor Author

this autopep8 is not enough, it's a start but some "manual" work needs to be done.

running flake8 on the source code finds 297 things to fix.

$ flake8 | wc -l
297

I'll try to find some time to take a look at this at some point, but feel free to start fixing things since you know the code well... ;-)

@flesueur
Copy link
Contributor

Okay, lots of lines :)

Most of them are star imports, thanks for the tip I'll try to fix them, I should have some time to work on SHSD in a few weeks...

@flesueur
Copy link
Contributor

First pass done, I corrected most of flake8 warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arthurlutz @flesueur