-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #12661 Null Reference Exception: System.Windows.Forms.TabControl.<WmSelChange> #12683
Fix #12661 Null Reference Exception: System.Windows.Forms.TabControl.<WmSelChange> #12683
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12683 +/- ##
====================================================
+ Coverage 76.03186% 97.02571% +20.99385%
====================================================
Files 3181 1191 -1990
Lines 639670 355480 -284190
Branches 47215 5446 -41769
====================================================
- Hits 486353 344907 -141446
+ Misses 149797 9770 -140027
+ Partials 3520 803 -2717
Flags with carried forward coverage won't be shown. Click here to find out more. |
src/System.Windows.Forms/src/System/Windows/Forms/Controls/TabControl/TabControl.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/TabControlTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/TabControlTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/TabControlTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I added a comment about a test
…utomationEventRaised() test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Please work with Leaf to get this ported to the release/9 and release/8 branches.
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/winforms/actions/runs/12664765466 |
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/winforms/actions/runs/12664783112 |
@LeafShi1 backporting to release/8.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix issue 12661 and add unit test
Using index info to reconstruct a base tree...
A src/System.Windows.Forms/src/System/Windows/Forms/Controls/TabControl/TabControl.cs
M src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/TabControlTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/TabControlTests.cs
Auto-merging src/System.Windows.Forms/src/System/Windows/Forms/TabControl.cs
CONFLICT (content): Merge conflict in src/System.Windows.Forms/src/System/Windows/Forms/TabControl.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix issue 12661 and add unit test
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
…ntrol.<WmSelChange> (dotnet#12683) * Fix issue 12661 and add unit test * Updated the unit test code lines to resolve the conversations from Tanya * Updated the BeginInvoke delegate in WmSelChange() * Removed that TabControl_WmSelChange_AccessibilityObjectNotCreated_NoAutomationEventRaised() test * Removed the unnecessary code lines from TabControlTests.cs file.
…ntrol.<WmSelChange> (dotnet#12683) * Fix issue 12661 and add unit test * Updated the unit test code lines to resolve the conversations from Tanya * Updated the BeginInvoke delegate in WmSelChange() * Removed that TabControl_WmSelChange_AccessibilityObjectNotCreated_NoAutomationEventRaised() test * Removed the unnecessary code lines from TabControlTests.cs file.
Fixes #12661
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
Throw exception in Application.Run()
After
No exception in runtime
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow