Remove dependency on RemoteExecutor on some files #12379
Draft
+25
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobossan
force-pushed
the
Issue_4500_Remove_Dependency_On_RemoteExecutor_In_Tests
branch
from
e3d91a7 to
4b05a67
Compare
ricardobossan
force-pushed
the
Issue_4500_Remove_Dependency_On_RemoteExecutor_In_Tests
branch
from
4b05a67 to
acddbd1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12379 +/- ##
===================================================
+ Coverage 76.03858% 76.12353% +0.08495%
===================================================
Files 3181 3187 +6
Lines 639670 639990 +320
Branches 47215 47229 +14
===================================================
+ Hits 486396 487183 +787
+ Misses 149756 149269 -487
- Partials 3518 3538 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
| public void ParkingWindow_DoesNotThrowOnGarbageCollecting() | ||
| { | ||
| using RemoteInvokeHandle invokerHandle = RemoteExecutor.Invoke(() => | ||
| Task.Run(() => | ||
| { | ||
| Control.CheckForIllegalCrossThreadCalls = true; |
There was a problem hiding this comment.
Because this test modifies a static value, it should run in a sequential collection( move it to a new file, like Leaf did) and it should set the static back to the initial value using a try/fianally blocks
Tanya-Solyanik
added
the
📭 waiting-author-feedback
ricardobossan
force-pushed
the
Issue_4500_Remove_Dependency_On_RemoteExecutor_In_Tests
branch
from
acddbd1 to
dd8fb7a
Compare
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
ricardobossan
force-pushed
the
Issue_4500_Remove_Dependency_On_RemoteExecutor_In_Tests
branch
from
4ddda8b to
22a7e71
Compare
ricardobossan
force-pushed
the
Issue_4500_Remove_Dependency_On_RemoteExecutor_In_Tests
branch
from
22a7e71 to
db59ce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow