Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify CreateTempSubdirectory #45633

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

simplify CreateTempSubdirectory #45633

wants to merge 2 commits into from
+18 −74

Conversation

kasperk81
Copy link
Contributor

@kasperk81 kasperk81 commented Dec 27, 2024 •
edited
Loading

InternalAbstractions netstandard support is only needed by Microsoft.NET.TestFramework.csproj. for that CreateTempSubdirectory is using p/invoke for all dependents

making InternalAbstractions multi-framework same as Microsoft.NET.TestFramework.csproj to simplify CreateTempSubdirectory and deleting unused methods

#45631

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 27, 2024
@build-analysis build-analysis bot mentioned this pull request Dec 27, 2024
Open
3 tasks
@kasperk81
Copy link
Contributor Author

@marcpopMSFT @baronfel can we backport it to 9.0.2xx?

@marcpopMSFT marcpopMSFT requested a review from nagilson January 8, 2025 23:25
nagilson
nagilson reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment on #45631 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagilson nagilson nagilson left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperk81 @nagilson