Description

The source generator in Microsoft.Extensions.Logging.Abstractions throws OverflowException when it attempts to generate an EventId for some logger method names. Pronounceable names that trigger this error include Dzoggee, Juzzwenn, Bzuengdom, Covieeszu, Ennudkilw, Fawiinska, Haikshyke, Hyklyytja, Kirraphas, Nuthvausu, Orluavjee, Piaanwatz, Ponkpauij, Ruakszyrn, and Sazkwinuo.

Reproduction Steps

EventIdHashOverflow.csproj:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
    <Nullable>enable</Nullable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.2" />
  </ItemGroup>

</Project>

LoggerExtensions.cs:

using Microsoft.Extensions.Logging;

namespace EventIdHashOverflow
{
    internal static partial class LoggerExtensions
    {
        [LoggerMessage(Level = LogLevel.Information)]
        public static partial void Dzoggee(this ILogger logger);
    }
}

Attempt to build this project.

Expected behavior

The build should succeed.

Actual behavior

CSC : warning CS8785: Generator 'LoggerMessageGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'OverflowException' with message 'Negating the minimum value of a twos complement number is invalid.'.

LoggerExtensions.cs(8,36,8,43): error CS8795: Partial method 'LoggerExtensions.Dzoggee(ILogger)' must have an implementation part because it has accessibility modifiers.

Regression?

No response

Known Workarounds

Specify LoggerMessageAttribute.EventId instead of letting it be generated automatically.

Configuration

.NET SDK 9.0.101

Other information

OverflowException is thrown by the Math.Abs(Int32.MinValue) call here:

There is similar code in other source generators too:

• runtime/src/libraries/Microsoft.Extensions.Options/gen/OptionsSourceGenContext.cs

  Lines 68 to 81 in 5a9362f

  	/// <summary>
  	/// Returns a non-randomized hash code for the given string.
  	/// We always return a positive value.
  	/// </summary>
  	internal static int GetNonRandomizedHashCode(string s)
  	{
  	uint result = 2166136261u;
  	foreach (char c in s)
  	{
  	result = (c ^ result) * 16777619;
  	}
  	return Math.Abs((int)result);
  	}

• https://github.com/dotnet/extensions/blob/16acdbf1442f579862cfea15ffd0782510078ff0/src/Generators/Microsoft.Gen.Logging/Emission/Emitter.Method.cs#L141-L159

Making GetNonRandomizedHashCode return 0 in this case would make every nonnegative int return value correspond to two values of uint result.