-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specialized FrozenSet implementations for byte and char #110842
Open
MihaZupan
wants to merge
5
commits into
dotnet:main
Choose a base branch
from
MihaZupan:frozenset-bytechar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+593
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
reviewed
Dec 19, 2024
src/libraries/System.Collections.Immutable/src/System/Collections/Frozen/Byte/ByteFrozenSet.cs
Outdated
Show resolved
Hide resolved
This was referenced Dec 20, 2024
src/libraries/System.Private.CoreLib/src/System/SearchValues/BitVector256.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/SearchValues/ProbabilisticMapState.cs
Show resolved
Hide resolved
.../System.Collections.Immutable/src/System/Collections/Frozen/Char/PerfectHashCharFrozenSet.cs
Show resolved
Hide resolved
cc: @dotnet/area-system-collections (the bot was lazy) |
Can you point to some places where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110783
Adds 3 new
FrozenSet
imlpementations:ByteFrozenSet
- any set of bytes when using the default comparerLatin1CharFrozenSet
- set of chars <= 255 when using the default comparerPerfectHashCharFrozenSet
- any set of chars when using the default comparerI extracted the lookup logic from
ProbabilisticMapState
inSearchValues
to a searate helper so that there's practically no code duplication between the two.Benchmark
char.IsSymbol
(Latin1CharFrozenSet
)char.IsAscii && char.IsSymbol
(PerfectHashCharFrozenSet
)char.IsSymbol
forbyte
s (ByteFrozenSet
)