Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "no cdn" concept from install script. #563

Open
richlander opened this issue Jan 6, 2025 · 3 comments · May be fixed by #564
Open

Remove "no cdn" concept from install script. #563

richlander opened this issue Jan 6, 2025 · 3 comments · May be fixed by #564
Assignees
@JanProvaznik

Comments

@richlander
Copy link
Member

This is an anti-pattern.

install-scripts/src/dotnet-install.sh

Lines 1408 to 1412 in 33dc34f

if [[ "$no_cdn" == "true" ]]; then
feeds=(
"https://dotnetcli.blob.core.windows.net/dotnet"
"https://dotnetbuilds.blob.core.windows.net/public"
)

This was referenced Jan 6, 2025
Open
Draft
@baronfel
Copy link
Member

baronfel commented Jan 6, 2025

I'm slightly concerned about removing functionality here, but I do not see much usage in public at all. Most of the usage seems to be from a thing called "ray-dotnet-install.sh". I think we can cut it, though.

@baronfel
Copy link
Member

baronfel commented Jan 6, 2025

@JanProvaznik this one as well :)

@richlander
Copy link
Member Author

Even if people are using it, it isn't something we should be offering or encouraging.

This was referenced Jan 7, 2025
Open
Merged
@JanProvaznik JanProvaznik self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanProvaznik JanProvaznik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove no-cdn concept, remove azureedge links JanProvaznik/install-scripts
3 participants
@baronfel @richlander @JanProvaznik