Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling problem in the Event History panel #312

Closed
Gregg8 opened this issue Jun 25, 2021 · 3 comments · Fixed by #374
Closed

Scrolling problem in the Event History panel #312

Gregg8 opened this issue Jun 25, 2021 · 3 comments · Fixed by #374
Assignees
Milestone

Comments

@Gregg8
Copy link
Contributor

Gregg8 commented Jun 25, 2021

When you select an event in the Event History panel, 10x will continuously scroll back to that event, which prevents you from scrolling to other events to view them.

In fact, the scrolling back only seems to happen when you've expanded the data for that event.

@superstructor superstructor added this to the v1.2.2 milestone Nov 4, 2021
@Gregg8
Copy link
Contributor Author

Gregg8 commented Mar 18, 2022

This might be good to add to: #302

@superstructor superstructor removed this from the v1.2.2 milestone Jun 7, 2022
@superstructor superstructor assigned MawiraIke and unassigned MawiraIke Jun 7, 2022
@superstructor superstructor added this to the v1.4.0 milestone Jun 7, 2022
@superstructor superstructor modified the milestones: v1.4.0, v1.5.0 Jun 19, 2022
@MawiraIke
Copy link
Contributor

This issue is caused by triggering of componentDidUpdate in the lifecycle of selected epochs. I have been able to reproduce the issue when leaving mouse hover on a selected epoch. It seems that componentDidUpdate is triggered every time the mouse hovers (or leaves mouse hover) on a selected epoch. I think this is because we are tracking the current hovered epoch and updating the style of epochs depending on the mouse hover. This then updates the DOM and indirectly triggers the componentDidUpdate method. So every time a user moves the mouse from the selected epoch to another NOT selected epoch, we indirectly call componentDidUpdate and cause the DOM to scroll to the selected epoch again.
@superstructor my suggestion is to stop listening to componentDidUpdate unless there was another intention of the callback that I have not discovered. Removing the callback seems to fix the issue.

@superstructor
Copy link
Contributor

Ok thanks @MawiraIke I've reviewed the linked code and agree yes please stop listing to componentDidUpdate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants