-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling problem in the Event History panel #312
Comments
This might be good to add to: #302 |
This issue is caused by triggering of componentDidUpdate in the lifecycle of selected epochs. I have been able to reproduce the issue when leaving mouse hover on a selected epoch. It seems that componentDidUpdate is triggered every time the mouse hovers (or leaves mouse hover) on a selected epoch. I think this is because we are tracking the current hovered epoch and updating the style of epochs depending on the mouse hover. This then updates the DOM and indirectly triggers the componentDidUpdate method. So every time a user moves the mouse from the selected epoch to another NOT selected epoch, we indirectly call componentDidUpdate and cause the DOM to scroll to the selected epoch again. |
Ok thanks @MawiraIke I've reviewed the linked code and agree yes please stop listing to componentDidUpdate. |
When you select an event in the Event History panel, 10x will continuously scroll back to that event, which prevents you from scrolling to other events to view them.
In fact, the scrolling back only seems to happen when you've expanded the data for that event.
The text was updated successfully, but these errors were encountered: