Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-use this for single row parsing #27

Open
behrica opened this issue Oct 9, 2024 · 1 comment
Open

re-use this for single row parsing #27

behrica opened this issue Oct 9, 2024 · 1 comment

Comments

@behrica
Copy link

behrica commented Oct 9, 2024

I am working on a csv reader, which does custom "text->numbers" conversion while it reads tehe rows.
(it does this row-by-row) (it converts the text on-the-fly into a tid-text-format, one row per token.

So I cannot use the CsvReader but was hoping that I can re-use the logic of parsing a "single row" into the fields.

But I did not see, if this is possible, I don't think so.

@cnuernber
Copy link
Owner

cnuernber commented Nov 10, 2024

Why exactly does it seem not possible? Would I just need to make private functions public in the CSVReader class or make it not final - what would you need to reuse this class? The RowReader uses it externally like I think you intend to so in that sense it seems like it is possible to make your own unrelated row-reader-type thing and call the same?

Are you concerned about duplicating the logic here?

Could you provide a different implementation of JSONReader.ArrayReader?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants