Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎯 Make QuickQanava warning-free with respect to qmllint #248

Open
emmenlau opened this issue Sep 6, 2024 · 1 comment
Open

🎯 Make QuickQanava warning-free with respect to qmllint #248

emmenlau opened this issue Sep 6, 2024 · 1 comment

Comments

@emmenlau
Copy link
Contributor

emmenlau commented Sep 6, 2024

In recent versions of Qt (at least since 6.7.2), the tool qmllint has become much more helpful. We are using it now on a regular basis to validate our QML code.

In this process, I have seen that QuickQanava does not currently work well with qmllint. Just using QuickQanava in a project will trigger a large number of warnings, for example:

[build] Warning: /home/user/Source/qml/PipelineRunnerPage.qml:96:24: Qan.Graph was not found. Did you add all import paths? [import]
[build]                 graph: Qan.Graph {
[build]                        ^^^
[build] Warning: /home/user/Source/qml/PipelineRunnerPage.qml:105:35: Qan.NodeItem was not found. Did you add all import paths? [import]
[build]                     nodeDelegate: Qan.NodeItem {
[build]                                   ^^^
[build] Warning: /home/user/Source/qml/PipelineRunnerPage.qml:125:25: Qan.RectNodeTemplate was not found. Did you add all import paths? [import]
[build]                         Qan.RectNodeTemplate {
[build]                         ^^^
[build] Warning: /home/user/Source/qml/PipelineRunnerPage.qml:105:35: Qan.NodeItem was not found. Did you add all import paths? [import]
[build]                     nodeDelegate: Qan.NodeItem {
[build]                                   ^^^
[build] Warning: /home/user/Source/qml/PipelineRunnerPage.qml:79:13: Qan.GraphView was not found. Did you add all import paths? [import]
[build]             Qan.GraphView {
[build]             ^^^

There are quite a lot more related warnings.

When using modern cmake features on QuickQanava, all the types should be automatically detected and exported with the module. There is no longer a need to maintain manually the qmldir files.

cneben added a commit that referenced this issue Sep 8, 2024
Still don't work. WIP.

Signed-off-by: cneben <[email protected]>
cneben added a commit that referenced this issue Sep 8, 2024
…curs.

WIP, still not working. Define an explicit ressource file ?

Signed-off-by: cneben <[email protected]>
cneben added a commit that referenced this issue Sep 8, 2024
cneben added a commit that referenced this issue Sep 8, 2024
WIP.
Incredibly faster with qmlc...

Signed-off-by: cneben <[email protected]>
cneben added a commit that referenced this issue Sep 8, 2024
@cneben
Copy link
Owner

cneben commented Sep 8, 2024

Note for self: BTW, using qmltc (https://doc.qt.io/qt-6/qtqml-qml-type-compiler.html) for node / edge component could be interesting.

cneben added a commit that referenced this issue Sep 8, 2024
Signed-off-by: cneben <[email protected]>
cneben added a commit that referenced this issue Sep 22, 2024
cneben added a commit that referenced this issue Sep 22, 2024
cneben added a commit that referenced this issue Sep 22, 2024
cneben added a commit that referenced this issue Sep 22, 2024
cneben added a commit that referenced this issue Sep 22, 2024
cneben added a commit that referenced this issue Sep 22, 2024
@cneben cneben changed the title Make QuickQanava warning-free with respect to qmllint 🎯 Make QuickQanava warning-free with respect to qmllint Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants