Remove duplicate checkstyle.jar #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove and gitignore the checkstyle.jar in eclipsecs.core * have only the copy in eclipsecs.checkstyle remain * export packages of transitive dependencies from the eclipsecs.checkstyle project. this is not a good practice, but represents exactly what happened before: consuming the third party dependencies from the checkstyle library fixes checkstyle#385 In a follow-up change the re-exported packages should be removed, and instead be replaced by taking the respective libraries into the target platform.
Bananeweizen
force-pushed
the
duplicate_jar
branch
from
435b2bd to
73222fe
Compare
|
Merging, so I can continue with other PRs that modify the classpath and dependency chain. Feel free to still raise issues or comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #385
In a follow-up change the re-exported packages should be removed, and instead be replaced by taking the respective libraries into the target platform.
Please be aware this change is based on #684 and #681, therefore those should be merged first.