Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require maxRetries to be non-negative #357

Open
ebarreras opened this issue Nov 29, 2021 · 1 comment
Open

Require maxRetries to be non-negative #357

ebarreras opened this issue Nov 29, 2021 · 1 comment

Comments

@ebarreras
Copy link

When creating a policy with limitRetries, it seems that it should be illegal to pass a negative number as in RetryPolicies.limitRetries[IO](-3), however these values are not rejected.
@ebarreras
Copy link
Author

I have pushed a possible fix in https://github.com/ebarreras/cats-retry/commits/require-max-retries-non-negative. If that makes sense I'd be happy to create a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ebarreras