Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing the prefillParallelism argument in redis.go #76

Open
0x9k opened this issue Aug 5, 2019 · 0 comments
Open

missing the prefillParallelism argument in redis.go #76

0x9k opened this issue Aug 5, 2019 · 0 comments

Comments

@0x9k
Copy link

0x9k commented Aug 5, 2019 

go/src/github.com/benmanns/goworker/redis.go:35:30: not enough arguments in call to pools.NewResourcePool

In vitess.io/vitess/go/pools the NewResourcePool is defined as

NewResourcePool(factory Factory, capacity, maxCap int, idleTimeout time.Duration, prefillParallelism int) *ResourcePool

Is missing the argument prefillParallelism in redis.go?

return pools.NewResourcePool(newRedisFactory(uri), capacity, maxCapacity, idleTimout, 0)
or
return pools.NewResourcePool(newRedisFactory(uri), capacity, maxCapacity, idleTimout, 1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0x9k