-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when closing file #1199
Labels
bug
Something isn't working
Comments
Hello, thank you for making this report. From the logs, it appears that your S3 implementation is returning a 412 precondition failed response to Mountpoint. Running with |
Hi, here's the log with the extra information from |
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 7, 2025
We recently saw an error in #1199 where "Header not found" was emitted, but its really unclear what header was missing. 2024-12-12T18:33:59.379478Z WARN flush{req=1609 ino=2 fh=1 pid=29257 name="testfile_100M.bin"}: mountpoint_s3::fuse: flush failed: put failed: put request failed: Client error: Internal S3 client error: Header not found This change updates the `HeadersError::HeaderNotFound` enum variant to contain a copy of the header name, such that error messages can emit it for debugging purposes. It may make more sense to have all the header names we use statically defined somewhere, such that we could include a static reference to the header and avoid allocating for an error message. However, we don't expect there to be any performance regression introduced by this change. This move to static values could be made later. ### Does this change impact existing behavior? Header not found and invalid header value errors will now include the header name when printing the error message. The enum variants change meaning any code using the enum may be impacted. ### Does this change need a changelog entry? Not for Mountpoint itself. I have added a change log entry to `mountpoint-s3-crt` since it is a breaking API change. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Daniel Carl Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Mountpoint for Amazon S3 version
mount-s3 1.13.0
AWS Region
NA
Describe the running environment
A Centos7 vm connecting to a non-AWS S3 provider, based on OpenStack and CEPH
Mountpoint options
What happened?
Attempted to copy a file to the bucket throws i/o error when closing the file. The file is actually well-written (verified by sha256sum checksum).
Relevant log output
The text was updated successfully, but these errors were encountered: