add helm OCI repo fail "URL should include hostname and port only"

[SvenGuthe]

Discussed in #15876

^{Originally posted by lovesharepc October 9, 2023}
my registry server is harbor with port 1843

when use command

argocd repo add 192.168.100.150:1843  --type helm --name helm-charts --enable-oci --username admin --password Harbor12345  --insecure-skip-server-verification

get error message

FATA[0000] rpc error: code = Unknown desc = error testing repository connectivity: OCI Helm repository URL should include hostname and port only

how do I solve this ?

[SvenGuthe]

I now found the line where the error is thrown:

argo-cd/reposerver/repository/repository.go

Line 2580 in 1a9f226

return errors.New("OCI Helm repository URL should include hostname and port only")

argo-cd/util/helm/client.go

Lines 396 to 403 in 1a9f226

	func IsHelmOciRepo(repoURL string) bool {
	if repoURL == "" {
	return false
	}
	parsed, err := url.Parse(repoURL)
	// the URL parser treat hostname as either path or opaque if scheme is not specified, so hostname must be empty
	return err == nil && parsed.Host == ""
	}

I wrote myself a little test:

package main

import (
	"fmt"
	"net/url"
)

func IsHelmOciRepo(repoURL string) bool {
	if repoURL == "" {
		return false
	}
	parsed, err := url.Parse(repoURL)

	// the URL parser treat hostname as either path or opaque if scheme is not specified, so hostname must be empty
	return err == nil && parsed.Host == ""
}

func main() {
	fmt.Println(IsHelmOciRepo("192.168.100.150:1843"))
}

The result is false.

We should add a condition which allows pure IPs with optional Ports like

func IsHelmOciRepo(repoURL string) bool {
	if net.ParseIP(repoURL) != nil {
		return true
	}

	host, port, err := net.SplitHostPort(repoURL)

	if net.ParseIP(host) != nil {
		if p, err := strconv.Atoi(port); err == nil && p > 0 && p < 65536 {
			return true
		}
	}

	if repoURL == "" {
		return false
	}
	parsed, err := url.Parse(repoURL)

	// the URL parser treat hostname as either path or opaque if scheme is not specified, so hostname must be empty
	return err == nil && parsed.Host == ""
}