Improve Ample logging for rejected conditional mutations #5219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddanielr
reviewed
Dec 31, 2024
keith-turner
reviewed
Jan 6, 2025
...r/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/CleanUpBulkImport.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/accumulo/manager/compaction/coordinator/commit/CommitCompaction.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/delete/ReserveTablets.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/merge/DeleteRows.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Keith Turner <[email protected]>
keith-turner
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5202
Adds an overloaded
submitmethod to accept a description for the conditional mutation. This description gets logged if the mutation is rejected.Used this new overloaded submit method in AmpleConditionalWriterIT to make sure it works. I am not too sure where other good spots to use this are but will continue to look into it.