Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Transpiled JavaScript workflow fails for Dependabot PRs #986

Open
arianvp opened this issue Dec 23, 2024 · 2 comments
Open

Check Transpiled JavaScript workflow fails for Dependabot PRs #986

arianvp opened this issue Dec 23, 2024 · 2 comments
Assignees

Comments

@arianvp
Copy link

arianvp commented Dec 23, 2024

Closely related to #957 but different.

When you use this repo as a template, all dependabot PRs that are opened will fail as they do not regenerate the dist folder.

Is there a way to make dependabot do that or to not have the weird requirement to commit compiled code?

Because currently dependabot creates a lot of churn because all the PRs it opens will fail

@arianvp arianvp changed the title Check Transpiled JavaScript action fails for Dependabot PRs Check Transpiled JavaScript workflow fails for Dependabot PRs Dec 23, 2024
@arianvp
Copy link
Author

arianvp commented Dec 23, 2024

It would be great if there would be a way to not commit the dist folder. Can’t we publish releases to GitHub Packages or something?

@ncalteen
Copy link
Collaborator

ncalteen commented Jan 2, 2025

Yeah it can be a nuisance with dependency updates, since the dist/ directory can be modified when non-development dependencies are updated. I tested this out a few different ways, and it is possible to set up a GitHub Action that ensures the dist/ directory is rebuilt on Dependabot PRs, however I opted not to include this in the template because its way too easy to end up with infinite loops when GitHub Actions runs and updates the PR branch.

I'm waiting on Immutable Actions to go GA before trying another approach. In the meantime, you may want to checkout the container action template instead. This one is pretty straightforward to set up so the container pulls the dependencies and builds as part of your CI pipeline.

@ncalteen ncalteen self-assigned this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants