Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on unknown license instead of ignoring it #857

Open
mabar opened this issue Dec 28, 2024 · 2 comments
Open

Fail on unknown license instead of ignoring it #857

mabar opened this issue Dec 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mabar
Copy link

mabar commented Dec 28, 2024

Is your feature request related to a problem? Please describe.
When license of the package is unrecognized, this action still finishes successfully. Due to this problem we can easily miss usage of a package with an incompatible license.

For now I am setting comment-summary-in-pr to always instead of on-failure to notice problem but it does not allow me to prevent merge by branch protection and it posts useless comments when no dependencies changed.

Describe the solution you'd like
Add option fail-on-unknown-license: true

Describe alternatives you've considered
No config, just always fail on unknown.

Additional context
image

@mabar mabar added the enhancement New feature or request label Dec 28, 2024
@Dandy502
Copy link

fail-on-unknown-license: true

¿Su solicitud de función está relacionada con un problema? Descríbalo. Cuando no se reconoce la licencia del paquete, esta acción se completa correctamente. Debido a este problema, es fácil que no podamos utilizar un paquete con una licencia incompatible.

Por ahora estoy configurando comment-summary-in-pren alwayslugar de on-failurenotar el problema, pero no me permite evitar la fusión por protección de rama y publica comentarios inútiles cuando no se cambiaron dependencias.

Describe la solución que deseas Agregar opciónfail-on-unknown-license: true

Describe las alternativas que has considerado . Sin configuración, siempre falla en lo desconocido.

Contexto adicional imagen

@Dandy502
Copy link

fail-on-unknown-license: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants