Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hapi v17 #5

Open
henrikruscon opened this issue Jan 3, 2018 · 3 comments
Open

Hapi v17 #5

henrikruscon opened this issue Jan 3, 2018 · 3 comments

Comments

@henrikruscon
Copy link

henrikruscon commented Jan 3, 2018 •
edited
Loading

I made a PR #4 that updates hapi-relax to Hapi v17 but it lacks full testing coverage.

Would be sweet if anyone is able to contribute ✌️

Basically nock has to be updated and stop using nockDone(), same with lab where it has to stop using done(). Additionally the register method of plugins is incorrect, it has to be a promise or async/await. Finally the config needs to replace register with plugin.
@henrikruscon henrikruscon mentioned this issue Jan 3, 2018
Closed
3 tasks
@dkolba
Copy link
Member

dkolba commented Jan 24, 2018

@henrikdahl we are not actively using this library atm, would you be willing to maintain it yourself?

@henrikruscon
Copy link
Author

@dkolba Sure ✌️

@dkolba
Copy link
Member

dkolba commented Jan 24, 2018

@henrikdahl alright, you are a collaborator now. Have fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkolba @henrikruscon