Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make JSON a first class citizen? #142

Open
hilt86 opened this issue Oct 7, 2022 · 2 comments
Open

Can we make JSON a first class citizen? #142

hilt86 opened this issue Oct 7, 2022 · 2 comments

Comments

@hilt86
Copy link

hilt86 commented Oct 7, 2022

Thanks again for making Zat - I'm surprised it isn't being used by more folks!

In reference to https://github.com/SuperCowPowers/zat/blob/7f0de8bb052e8c84ab9bd00f195514d957eac9ec/zat/json_log_to_dataframe.py which states :

"""JSONLogToDataFrame: Converts a Zeek JSON log to a Pandas DataFrame
    Notes:
        Unlike the regular Zeek logs, when you dump the data to JSON you lose
        all the type information. This means we have to guess/infer a lot
        of the types, we HIGHLY recommend that you use the standard Zeek output
        log format as it will result in both faster and better dataframes.
    Todo:
        1. Have a more formal column mapping
        2. Convert Categorial columns
"""

What needs to be done so that we can have JSON as a first class citizen in Zat? Heaps of other tools rely on Zeek logs being json (Elastic Agent integration, Rita, etc) so it is a bummer that in order to use Zat we need to use ascii logging..

@brifordwylie
Copy link
Member

Thanks for your interest in improving the JSON reader. If the ZAT code is being used in a commercial setting and you'd like to get stuff done quickly and per specification you can always touch base with the SCP folks at https://www.supercowpowers.com/. Otherwise I agree with your suggestion that the JSON reader needs to be improved and we'll put this on the open source queue. I think the S3 bucket read suggestion is also top on the list 👍

@hilt86
Copy link
Author

hilt86 commented Oct 27, 2022

ok I will cancel my sponsorship here and get in touch with you directly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants