-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance] Auto rename to have other rename fucntionality like pdfgrep #330
Comments
Can you elaborate what you are trying to achieve |
Existing auto rename functionality renamed based on top x lines by looking at what has the largest font This could be enhanced by saying check x lines Or based on y regex So if I wanted a doc to be renamed based on company name in pdf I could do regex Company: ([a-z]+) or something |
Or the other options I listed above as well as regex can be complex for some people |
I have a use case here to illustrate how to get a first stab at this. Sure this applies to many a document you can download.. (Some Bank Statements often end up with weird filenames) |
Hi @Frooodle, I'd like to work on this enhancement. The proposed features sound great, and I'd be excited to contribute to improving the auto rename functionality. I'll start by exploring the existing codebase and planning out the implementation for the new renaming options. Please let me know if there are any specific guidelines or additional information I should consider before getting started. Thanks! |
Please have a go! If you need help discord would be best to reach out on |
Hi @Frooodle, Thank you for the approval and the guidance. I'll start working on the implementation as planned. However, before I dive in, could you provide some pointers on where in the codebase the current auto rename functionality is implemented? Any specific files or functions I should focus on initially would be very helpful. I'll join the Discord channel for further questions and discussions as well. Thanks again for the opportunity to contribute and for your assistance! |
Honestly it should only touch those files, anything else you should get by via referencing that java class, such as extra params you need to edit ExtractHeaderRequest.java etc |
Hi @Frooodle, Thank you for providing the links and the guidance. I’ll start by reviewing auto-rename.html and AutoRenameController.java to understand the current implementation and identify where to make the changes. I’ll also check out ExtractHeaderRequest.java and other relevant classes to ensure all necessary modifications are covered. If I have any specific questions or need further clarification as I work through this, I'll reach out on Discord. Thanks again for your support! |
Hi @Frooodle, I have completed the changes and raised a pull request for the enhancement. The updated version does the following:
You can review the pull request #1604. Please let me know if there are any further changes or improvements needed. I am happy to make adjustments as required. Thanks again for your guidance and support! Best regards, |
Use name of line that contains x
Use name of text that is between x and y
Use name Of x line number
Use name of text before/after x (for say name: Anthony S could be text after 'name:'
The text was updated successfully, but these errors were encountered: