Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require async feature for doctests and mosts tests #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jayvdb
Copy link
Collaborator

@jayvdb jayvdb commented Jan 7, 2025

Closes #292

@jayvdb jayvdb force-pushed the butane-test-fix branch 3 times, most recently from c7872f9 to 0c943e1 Compare January 7, 2025 23:42
@jayvdb
Copy link
Collaborator Author

jayvdb commented Jan 8, 2025

The alternative is to add the following

diff --git a/butane/Cargo.toml b/butane/Cargo.toml
index 6487f64..4184a54 100644
--- a/butane/Cargo.toml
+++ b/butane/Cargo.toml
@@ -36,6 +36,7 @@ r2d2 = { optional = true, workspace = true }
 deadpool = { optional = true, workspace = true }

 [dev-dependencies]
+butane = { workspace = true, features = ["async"] }
 butane_test_helper = { workspace = true }
 butane_test_macros = { workspace = true }
 cfg-if = { workspace = true }

happy to do that, if it is preferred.

@jayvdb jayvdb marked this pull request as ready for review January 8, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running butane tests fail unless async feature is enabled
2 participants