Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QC float division by zero should return nan #240

Open
divVerent opened this issue Jan 5, 2025 · 2 comments
Open

QC float division by zero should return nan #240

divVerent opened this issue Jan 5, 2025 · 2 comments

Comments

@divVerent
Copy link
Contributor

divVerent commented Jan 5, 2025 •
edited
Loading

Right now DP warns and returns 0.0.

I suggest keeping the warning (but possibly create an opt-out cvar for mods that rely on this way of getting a nan) but returning nan.

Should be done after #237.
divVerent added a commit that referenced this issue Jan 5, 2025
@divVerent
Make division by 0 return NAN when output is a floating point type, n…
0be808c 
…ot 0.

For now the division by zero warning is kept.

Fixed #240.
@divVerent
Copy link
Contributor Author

Created a branch divVerent/div_nan for this to be applied after #237.

divVerent added a commit that referenced this issue Jan 6, 2025
@divVerent
Make division by 0 return NAN when output is a floating point type, n…
95b1362 
…ot 0.

For now the division by zero warning is kept.

Fixed #240.
@divVerent
Copy link
Contributor Author

Let's put the new behavior behind a cvar, though, as nans can do quite some damage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@divVerent