URI_Get_Callback should provide the HTTP status code

[hemebond]

When using a web API, the HTTP status code is used to indicate the state of requests. Without this status code the client can't determine what to do next, e.g., re-sending the request, or showing an error to the players.

This behaviour also differs from FTEQW which does provide the HTTP status code, e.g.:

got response from URL request
Request ID: 1
Response code: 201
Response body: {"name":"3qyH9wNUhLo","status":4}

The help text in the dpextensions.qc actually says it should be returning an HTTP code:

//the following callback will receive the data and MUST exist!
//  void(float id, float status, string data) URI_Get_Callback;
//status is either
//  negative for an internal error,
//  0 for success, or
//  the HTTP response code on server error (e.g. 404)

[divVerent]

The extension actually says it should return 0 for success, and all 2xx and 3xx codes are success. This is important as QC code is expected to use != 0 to check for success in the return value.

I suggest providing a way for the caller to specify how non-200 success statuses should be handled (maybe some kind of flag to enable exposing the non-2xx success status?).

[hemebond]

You're right. I thought it also wasn't returning the HTTP status code for 404, because other errors were just giving me a -1, but it does show a 404. A flag sounds good.

[divVerent]

The alternative is changing the extension to only map 200 to 0, which may be OK to do.

But for that we first need to survey which other mods exist that use this, and if they would break from this.

[hemebond]

I think a flag that completely switches to HTTP status codes would be fine. I don't think the engine should be deciding what is a success or failure.