Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain skirts are causing artifacts in terrain shadows #11459

Open
calogeromauceri opened this issue Aug 7, 2023 · 1 comment
Open

Terrain skirts are causing artifacts in terrain shadows #11459

calogeromauceri opened this issue Aug 7, 2023 · 1 comment

Comments

@calogeromauceri
Copy link
Contributor

When terrain shadows are enabled, the skirts contribute in casting shadows causing shadows artifacts.

Screenshot 2023-08-07 16 56 34

This is better visible when the light source is tangent to surface (e.g. it is near the horizon).

I'm attaching a simple sandcastle example for demonstrating the current behavior: advance the time through the timeline for seeing the shadows artifacts caused by the skirts. Disabling the terrain skirts gets rid of some of those artifacts, but that of course has some other bad side effects, e.g. worse tiles edges connection

sandcastle

Sandcastle example:
Sandcastle

Ideally, I solid shadow should be casted when the light is low and the light source is occluded by a skirt "wall". Something like in the following animation

sandcastle_desired

Browser:
any

Operating System:
any

@calogeromauceri calogeromauceri changed the title Terrain skirts are casting shadows Terrain skirts are causing artifacts in terrain shadows Aug 7, 2023
@ggetz
Copy link
Contributor

ggetz commented Aug 11, 2023

Thanks for pointing this out @calogeromauceri!

We're reviewing your suggested fix in #11460.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants