Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compute migrations] Duplicated common types #2058

Open
AlitzelMendez opened this issue Jan 9, 2025 · 0 comments
Open

[Compute migrations] Duplicated common types #2058

AlitzelMendez opened this issue Jan 9, 2025 · 0 comments
Assignees

Comments

@AlitzelMendez
Copy link
Member

Problem: The SDK generation fails due to duplicated common types in each sub-service, causing duplicated schemas. This issue happens because common types are into each sub-service, leading to duplication.

Proposal: Create a decorator to handle common definitions. This decorator would prevent inlining common types into each sub-service's swagger and instead reference a common location. This approach aims to maintain back compatibility and avoid duplicated schemas

Implementation: Creating a decorator, such as @commonType, to reference common types from a centralized location. This would require manual adjustments to the TypeSpec files to ensure common types are correctly referenced and not duplicated.

Considerations: This will later require manual effort to update TypeSpec files.

Originally, it was mentioned to do this custom for this also applies to other services, not only compute, taking this into consideration, the decorator is not going to be a custom one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant