Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arm-common-types]: Validation for subscriptionId and resourceGroupName are inconsistent. #2050

Open
3 tasks done
dolauli opened this issue Jan 8, 2025 · 2 comments
Open
3 tasks done
Assignees
Labels
design:needed A design request has been raised that needs a proposal lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library triaged:core

Comments

@dolauli
Copy link

dolauli commented Jan 8, 2025

Service Team Contacts (Dev)

No response

Choose which kind of change this is

None

Describe the change, Provide the desired TypeSpec or json-schema for the change as appropriate.

For typespec, they are https://github.com/Azure/typespec-azure/blob/main/packages/typespec-azure-resource-manager/lib/common-types/types.tsp#L503-L522

For swagger common types:
For examples, for v3, they are https://github.com/Azure/typespec-azure/blob/main/packages/typespec-azure-resource-manager/lib/common-types/types.tsp#L503-L522. For v5, they are https://github.com/Azure/typespec-azure/blob/main/packages/typespec-azure-resource-manager/lib/common-types/types.tsp#L503-L522.

Link to documentation if available

No response

Additional notes or questions

No response

Checklist

  • Follow our Code of Conduct
  • Change is approved by Arm API Review
  • Please update issue title and choose the change type.
@dolauli dolauli added the lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library label Jan 8, 2025
@markcowl
Copy link
Member

markcowl commented Jan 8, 2025

for resource group name, the pattern restrictions does not appear to exist in any version of the common-types, this may come from ARM documentation however, and pattern restrictions are now required for all resource names.

For subscriptionId, the restrictions are consistent with each version (using the @typeChangedFrom marking

@markcowl markcowl added the design:needed A design request has been raised that needs a proposal label Jan 8, 2025
@markcowl markcowl added this to the [2025] February milestone Jan 8, 2025
@markcowl
Copy link
Member

markcowl commented Jan 8, 2025

est: 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design:needed A design request has been raised that needs a proposal lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library triaged:core
Projects
None yet
Development

No branches or pull requests

3 participants