[Bug]: typespec-autorest - path parameter should be excluded from the schema of request/response body

[dolauli]

Describe the bug

For example, in tsp of AzureFleet.Management, we have name as path parameter. See here for details.

We should exclude the path parameter name from the schema definition virtualMachineScaleSet for request/response body.

Reproduction

An example has been provided above.

Checklist

• Follow our Code of Conduct
• Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
• Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
• The provided reproduction is a minimal reproducible example of the bug.

[markcowl]

All resources have a name property:

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/types.json#L20-L24

[dolauli]

Hi @markcowl, AzureFleet case is different.

For models that inherit from ProxyResource, such as model CertificateProfile is ProxyResource<CertificateProfileProperties> {, I believe you are correct, since the root model Resource has a property called name.

However, the VirtualMachineScaleSet model does not inherit from ProxyResource. It is defined as model VirtualMachineScaleSet {.

I also reviewed the implementations of the C# and TypeScript generators, and they both ignore path parameters in the schema of the request/response body.

By the way,

My understanding of the following code is that name is only a path parameter, not both a path parameter and a body parameter. Is that correct?

Model xxx {
  @doc("The name of the virtualMachineScaleSet")
  @key("virtualMachineScaleSetName")
  @segment("virtualMachineScaleSets")
  @visibility("read")
  @path
  name: string;
}