Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: connectionStrings object value empty after deployments #4107

Open
1 task done
riosengineer opened this issue Dec 30, 2024 · 5 comments
Open
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@riosengineer
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/web/site

(Optional) Module Version

0.12.1

Description

Hi team,

I am unsure on why this is happening, but when you want to deploy connectionStrings via the web/sites/config via the AVM module web/site:0.12.1 (latest) it happily deploys the connection string name, type, but does not populate the value. I couldn't find any examples of this using AVM as the e2e test file does not seem to have it (from what I could see when searching): https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/web/site/tests/e2e/webConfig/main.test.bicep or https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/web/site/tests/e2e/webApp.max/main.test.bicep

I've reviewed the REST API and it doesn't seem like there's much to miss, besides the name, value and type for the siteConfig object:

https://learn.microsoft.com/en-us/azure/templates/microsoft.web/sites/config/connectionstrings?pivots=deployment-language-bicep and https://learn.microsoft.com/en-us/azure/templates/microsoft.web/sites/config?pivots=deployment-language-bicep#microsoftwebsitesconfig-objects

Example:

module appService 'br/public:avm/res/web/site:0.12.1' = {
  name: '${uniqueString(deployment().name, location)}-web'
  scope: resourceGroup(rgName)
.....
siteConfig: {
...
  connectionStrings: [
          {
            name: 'DefaultConnection'
            value: 'TestValue' 
            type: 'SQLAzure'
          }
        ]
Image

Of course, when I set it manually, all OK. Also it doesn't matter much what value I use, or if I use a custom type. Same issue.

(Optional) Correlation Id

8802f95a-fdef-4910-b371-433bb8d06d89

@riosengineer riosengineer added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 30, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Dec 30, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Dec 30, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Dec 30, 2024
Copy link

@riosengineer, thanks for submitting this issue for the avm/res/web/site module!

Important

A member of the @Azure/avm-res-web-site-module-owners-bicep or @Azure/avm-res-web-site-module-contributors-bicep team will review it soon!

@tsc-buddy
Copy link
Contributor

Hey @riosengineer -thanks for opening an issue. We shall schedule some time in Jan to triage this further.

Side note - the site/config--web is going to have some minor changes shortly so we will look at what you mentioned at the same time.

@riosengineer
Copy link
Author

Hey @riosengineer -thanks for opening an issue. We shall schedule some time in Jan to triage this further.

Side note - the site/config--web is going to have some minor changes shortly so we will look at what you mentioned at the same time.

Thanks buddy, look forward to the changes. Shout if you need any more info or testing!

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
Status: Needs: Triage
Development

No branches or pull requests

2 participants