Invalid Marshaling of ServerVulnerabilityProperties in SubAssessment

[bbernays]

Bug Report

The MarshalJSON() function for ServerVulnerabilityProperties the SDK is hardcoding the assessedResourceType as ServerVulnerabilityAssessment when in the sdk the const AssessedResourceTypeServerVulnerability has a value of ServerVulnerability

This means the following code will never return true:

func isTypeServerVulnerability(assessment *armsecurity.SubAssessment) bool {
    additionalType := assessment.Properties.AdditionalData.GetAdditionalData()
    return additionalType.AssessedResourceType == armsecurity.AssessedResourceTypeServerVulnerability
}

This value is also used in this function and will have to be changed as well

[github-actions]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @ArcturusZhang @lirenhe @tadelesh.

[jliusan]

@bbernays Our SDK is auto-generated from service spec: refer this. It looks like the spec definition is wrong. We need service team to fix the swagger first. If it is urgent, you can open a support ticket directly.

[bbernays]

Ok. So the current suggested workround is to not use the armsecurity.AssessedResourceTypeServerVulnerability const but instead just create a local variable to hold the expected value ServerVulnerabilityAssessment?