-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulley hangs on iOS 14 Beta 4 #390
Comments
This bug started showing up in 14b4, it's an auto layout loop caused by calling My guess is that this bug is being caused by a faster UI drawing brought by the latest beta, which causes a new re-draw while the call to |
Here's a good summary on how to debug auto-layout feedback loops. |
FYI still occurs on Beta 5. |
Around line 597: changing this:
to this:
Fixes it. I don't know this feature or codebase well enough to judge the implications of not running |
I can confirm this issue. Still present on beta 5. @pmacro Thank you for providing a proposal for a fix! Are you able to open a PR with the fix? |
@funkenstrahlen we only use |
…pports pannel mode. via issue #390
Hey! Thanks everyone for looking into this issue as I have not had a chance to dive into Xcode 12 yet. I have created the xcode12 branch to start looking into the beta issues with iOS 14 and have included the above patch for this issue, as well as the fix for if the drawer in |
Thank you for providing the However when I try to manually change the pulley position state it still starts to hang in an infinite loop. |
Hi! When can we expect an updated version of the SDK with the fix? |
@florianbuerger is this infinite loop happening when you call |
@ulmentflam I am not 100% sure what you mean. Do you mean in the patched version I linked in my first message? We have been using Pulley with that fix for a while now and we didn't encounter any more problems. There are no hangs anymore. We are calling I haven't had time to check out the |
I'm sorry @florianbuerger, I did mean to tag @funkenstrahlen in my question above who is testing on the |
@ulmentflam Ah, got it 😄 I'll see if I can test the |
Hi, I have tried this branch in xcode 12 but app hangs on launch. but it is working fine with xcode 11.
|
@sohail-niazi are you using Xcode 12 Beta 6? |
yes it is Xcode 12 beta 6. |
Hi @ulmentflam, I fully understand all the moving parts here, and that this may be an unreasonable question! But given the announcement that iOS 14 will be released tomorrow, could you please share your thoughts on the timing of this fix? Do you plan to have a compatible release ASAP, or do you plan to hold off until there is more clarity on reported issues, such as @sohail-niazi's? That information would help me, and hopefully others, who plan to release iOS 14 updates for their apps ASAP. Thank you! |
@pmacro I am planning to hold off until there is more clarity on the reported issues before getting this branch out specifically. I would like to get more clarity on @sohail-niazi's and @funkenstrahlen's issues before I release (as on the sample project I have not been able to replicate either of their issues on this branch). I want to get a fix for this issue out as soon as possible, as soon as I have clarity on these existing issues. That leads me to my next question for @sohail-niazi, Can you replicate this issue in the demo project for me? |
Unfortunately I will not be able to provide further input to this issue. I decided to go with a completely different approach and use system default modal views instead of Pulley in my app as I am trying to get the app compatible with macOS. This will be more easy with default system components in my case. |
@ulmentflam |
@ulmentflam I have tried demo project for xcode12 branch. It works fine but still I cant make it work(my project) on ios14, ios13 is running fine. I have vereified xcode12 branch changes after pod install. But App just gets stuck on launch and no logs even. UPDATE: |
@sohail-niazi have you made any customizations or tweeks to Pulley, or have you subclassed it? |
No.. I am using base PulleyViewController in my application. I was able to reproduce error on demo project. Steps to reproduce error: |
@sohail-niazi That's great! It looks like there is still an auto-layout feedback loop when the initial drawer position is set. I am looking into it now, thanks for the feedback! |
@ulmentflam Apparently PulleyViewController is running in infinite loop. It's viewDidLayoutSubviews() method is getting called in loop... |
Much appreciated speedy response. Thanks... |
@funkenstrahlen I know you are no longer using Pulley for your application, but were you by chance changing the position of the drawer to or from the |
Yes that's exactly what I did and that also caused the same 'hang' symptom. |
Issue is resolved in App. It is working fine now. The culprit was this code snippet:
removing It worked as expected. @ulmentflam Thank you very much for great support and response. |
@sohail-niazi No problem! Are you still on the |
@ulmentflam Yes I am. |
@emresa37 Are you still experiencing your issue on the |
@ulmentflam No it's fixed. Thank you for great support 👍 |
@ulmentflam also experienced the issue. 100% CPU, loop on layoutSubview.. |
@ulmentflam I just wanted to confirm: is the And as an aside, thanks for all your work on this release, especially given the short time scale Apple gave us all to have solid iOS 14 versions of our libraries. 👏 |
Hello, Pulley still hangs on iOS 14 when I set the view alpha, and I am using release 2.8.3.
|
@pmacro The |
@ulmentflam Thanks for the replies, I posted the logs here, I thought these would be useful. I was able to reappearance it via PullyDemo.
|
@150vb I just pushed a new fix for your issue to the |
@ulmentflam Thank you very much, I tested it and it worked fine. |
@ulmentflam your latest fix on |
For me it's fixed too. @ulmentflam good job. Thx you |
@150vb @benjaminmestrez @vladkos The latest from the |
As this is the home to all issues iOS 14 and Xcode 12, see comments for issues related to dragging scrollview in issue #400 |
More iOS 14 issues have been fixed in release 2.8.5. Please continue to report issues with iOS 14 as you run into them! |
App is stucking on launch screen as we are initializing the root view controller using pulley library in iOS14. I stucked in this issue from last 2 days. |
@ulmentflam I have it problem now (only on iphone 11 pro, 11 pro max, 12 pro/ iOS 14.4). Pulley version 2.9.0, xCode version 12.4. It works good on other devices. |
@Roman-swift It sounds like there is an auto layout feedback loop in your implementation of the PulleyDrawerViewControllerDelegate as I am not able to replicate this issue on the sample app. You can use this article to debug the auto layout feedback loop. |
After upgrading to iOS 14 Beta 4, even the example projects won't launch anymore and the CPU is at 100%. I didn't have time to investigate further so I don't know if this is a bug from iOS 14 or Pulley. It worked fine until iOS 14 Beta 3.
Anyway, a short term fix I found is to slightly delay the layout code for Pulley with a good old
DispatchQueue.main.asyncAfter(deadline: .now() + 0.1)
— which, in my initial testing — seems to resolve the issue. See for an example florianbuerger@ea6c287Just wanted to leave that here in case anyone else is running into it.
The text was updated successfully, but these errors were encountered: